-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to use GitHub App's "Checks API" instead of PR comments #936
Comments
Since this depends on atlantis being configured as a Github app, it seems to require #418 |
This would put atlantis more on-par with competitors like Spacelift https://docs.spacelift.io/integrations/source-control/github |
PRs will be welcome :) |
It appears the lyft fork has this setup and they previously attempted to upstream the changes here #2217 but it fell into git conflicts and became stale. If anyone is interested in taking the changes, fixing conflicts, testing, and opening up a new PR, then we can get it merged 😄 . Notable in the lyft fork. Edit: Using the checks api results in github app in a "job summary" (and "job summaries") style output (for issue searchers). It's also possible that a job summary output can be used with or without checks api meaning the github app is not 100% necessary for summaries. |
Would be nice to have this for Bitbucket cloud too |
Hi,
I'd like to propose using the "GitHub Checks API" for delivering even nicer feedback into GitHub pull requests.
Here's two examples of how it looks when the Google Cloud Build GitHub app does this:
Success example:
Failure example:
Some possible benefits:
Since the GitHub Checks API seems to require tying it to a GitHub app, I imagine it might mean each installation/usage of Atlantis might require the owners to set up their own private app, but that might be fine.
The text was updated successfully, but these errors were encountered: