Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init genesis in gov xmod #110

Merged
merged 14 commits into from
Jun 12, 2024
Merged

Init genesis in gov xmod #110

merged 14 commits into from
Jun 12, 2024

Conversation

NYBACHOK
Copy link
Collaborator

@NYBACHOK NYBACHOK commented Jun 4, 2024

Part of #117

@NYBACHOK NYBACHOK changed the title [WIP]: Add gov xmod Init genesis in gov xmod Jun 12, 2024
@NYBACHOK NYBACHOK requested review from joneskm and dmvict June 12, 2024 13:49
@NYBACHOK NYBACHOK linked an issue Jun 12, 2024 that may be closed by this pull request
*/

if !(balance == total_deposits) {
panic!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're expecting that in the bank module init genesis the gov_mod account will be initialized to the right amount?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. But I need to make sure that it created before usage(I suspected that It doesn't) and additional thing to note is denom.

x/gov/src/types/deposit.rs Outdated Show resolved Hide resolved
x/gov/src/types/proposal.rs Show resolved Hide resolved
x/gov/src/types/vote.rs Outdated Show resolved Hide resolved
@joneskm joneskm merged commit 62bd576 into rumos-io:main Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add gov xmod
2 participants