Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-api: Add registration token validity checking endpoint #757

Merged
merged 4 commits into from
Nov 9, 2021

Conversation

govynnus
Copy link
Contributor

@govynnus govynnus commented Nov 9, 2021

Proposed in MSC3231

https://github.com/matrix-org/matrix-doc/blob/main/proposals/3231-token-authenticated-registration.md#checking-the-validity-of-a-token

Closes #708

I only put the unstable-pre-spec attributes in account.rs, which I'm not sure is correct.
Also I couldn't find anywhere endpoints are tested (but didn't look very hard).

@govynnus govynnus requested a review from jplatte as a code owner November 9, 2021 11:38
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall, only some minor things need to be adjusted.

crates/ruma-client-api/src/r0/account.rs Outdated Show resolved Hide resolved
@jplatte jplatte enabled auto-merge (squash) November 9, 2021 12:07
@jplatte
Copy link
Member

jplatte commented Nov 9, 2021

@govynnus Can you rerun cargo fmt? The module declaration now needs to be further up.

auto-merge was automatically disabled November 9, 2021 12:16

Head branch was pushed to by a user without write access

@jplatte jplatte enabled auto-merge (squash) November 9, 2021 12:22
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@govynnus
Copy link
Contributor Author

govynnus commented Nov 9, 2021

No problem, sorry it took so long :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Implement MSC3231: Token authenticated registration
2 participants