Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text underlines are too high up #12128

Open
MrCheeze opened this issue Jul 17, 2023 · 1 comment
Open

Text underlines are too high up #12128

MrCheeze opened this issue Jul 17, 2023 · 1 comment
Labels
bug Something isn't working text Issues relating to text rendering/input

Comments

@MrCheeze
Copy link
Contributor

MrCheeze commented Jul 17, 2023 •
edited
Loading

Describe the bug

An example:

image
https://github.com/ruffle-rs/ruffle/tree/master/tests/tests/swfs/visual/text/underline_color

(EDIT: deleted a second example which was not actually this issue, it was just a different font being used.)

Expected behavior

Text underlines should be lower down, where they are in flash player.

Affected platform

Desktop app

Operating system

Windows 11

Browser

Mozilla Firefox

Additional information

No response
@MrCheeze MrCheeze added the bug Something isn't working label Jul 17, 2023
@Lord-McSweeney Lord-McSweeney added the text Issues relating to text rendering/input label Jul 17, 2023
@kjarosh
Copy link
Member

kjarosh commented Nov 23, 2024

Flash places the underline at - max_descent / 2, we currently place it at -2px.

@kjarosh kjarosh mentioned this issue Nov 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working text Issues relating to text rendering/input
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kjarosh @MrCheeze @Lord-McSweeney