Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for form format #4000

Merged
merged 9 commits into from
Jan 24, 2025
Merged

Conversation

sandeepdsvs
Copy link
Contributor

@sandeepdsvs sandeepdsvs commented Jan 22, 2025

What are the changes introduced in this PR?

  • Add support for form-urlencoded format. Send payload in body.FORM if format is FORM
  • Removed unwanted feature excludeMappedFields
  • Now throwing error if XML have multiple keys at root level and setting xmlns:xsi namespace

What is the related Linear task?

Resolves INT-2983

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (ba8ad19) to head (c3bd190).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4000      +/-   ##
===========================================
+ Coverage    90.78%   90.81%   +0.03%     
===========================================
  Files          624      626       +2     
  Lines        32553    32677     +124     
  Branches      7727     7757      +30     
===========================================
+ Hits         29552    29676     +124     
  Misses        2777     2777              
  Partials       224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandeepdsvs sandeepdsvs force-pushed the feat.form-format-support branch from e85a96a to 15afa4f Compare January 22, 2025 12:07
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@sandeepdsvs sandeepdsvs requested a review from koladilip January 22, 2025 13:47
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@sandeepdsvs sandeepdsvs requested a review from koladilip January 22, 2025 14:43
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

koladilip
koladilip previously approved these changes Jan 23, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

krishna2020
krishna2020 previously approved these changes Jan 23, 2025
@sandeepdsvs sandeepdsvs dismissed stale reviews from krishna2020 and koladilip via f74972e January 23, 2025 12:25
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@sandeepdsvs sandeepdsvs merged commit 1fc15bf into develop Jan 24, 2025
27 checks passed
@sandeepdsvs sandeepdsvs deleted the feat.form-format-support branch January 24, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants