chore: improve iterable network handler #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanpj2292
requested review from
shrouti1507
and removed request for
a team and
sivashanmukh
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3918/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix.iterable-networkhandler #3918 +/- ##
===============================================================
- Coverage 90.49% 90.49% -0.01%
===============================================================
Files 619 619
Lines 32440 32408 -32
Branches 7701 7691 -10
===============================================================
- Hits 29358 29328 -30
+ Misses 2858 2824 -34
- Partials 224 256 +32 ☔ View full report in Codecov by Sentry. |
|
shrouti1507
approved these changes
Dec 7, 2024
shrouti1507
merged commit 3789652
into
fix.iterable-networkhandler
23 of 24 checks passed
shrouti1507
added a commit
that referenced
this pull request
Jan 6, 2025
* fix: adding transformer proxy for iterable * fix: adding component test cases * fix: adding factory pattern * fix: code redesigning * fix: decoupling networkHandler and specific strategy * fix: simplifying logic * fix: convert to registry pattern * fix: converting to typescript * fix: removing unnecessary comments * fix: adding data delivery test cases for all endpoints * chore: improve iterable network handler (#3918) * chore: improve iterable network handler * chore: add comment in principal strategy class * chore: rename from PrincipalStrategy to BaseStrategy * chore: update expect-error comment --------- Co-authored-by: Sai Sankeerth <[email protected]> * fix: review comments addressed * fix: small refactoring * fix: update for supporting disallowed events * fix: code review suggestion Co-authored-by: Sankeerth <[email protected]> * fix: fixing test cases * fix: review comment addressed * fix: adding type definitions * fix: separating handle error functions * fix: migrating processor and router test cases * fix: review comment addressed --------- Co-authored-by: Sankeerth <[email protected]> Co-authored-by: Sai Sankeerth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
Provide more structure to the an improved network handler for Iterable destination.
What is the related Linear task?
Resolves INT-2901
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.