fix: linkedin ads conversionValue object as well as price is not mandatory #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/integrations/destinations/linkedin_ads/processor/validationTestData.ts
Dismissed
Show dismissed
Hide dismissed
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3860/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3860 +/- ##
===========================================
- Coverage 89.02% 89.01% -0.01%
===========================================
Files 610 610
Lines 32918 32950 +32
Branches 7779 7788 +9
===========================================
+ Hits 29305 29332 +27
+ Misses 3330 3305 -25
- Partials 283 313 +30 ☔ View full report in Codecov by Sentry. |
utsabc
approved these changes
Nov 8, 2024
ItsSudip
approved these changes
Nov 11, 2024
|
krishna2020
reviewed
Nov 11, 2024
| const message = { properties: {} }; | ||
| expect(() => { | ||
| fetchUserIds(calculateConversionObject(message)); |
There was a problem hiding this comment.
what was fetchUserIds doing before ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
We see from LinkedIn conversion API doc that conversionValue is an optional field. But we kept it mandatory because we were throwing an error if the
conversionValueobject elementpricewas absent from the payload.We verified it by sending API calls to LinkedIn without conversion value:
( data the screenshot contains are all dummy )
What is the related Linear task?
Resolves INT-2876
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.