Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add correct validation for purchase events #3766

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Sep 27, 2024

What are the changes introduced in this PR?

In Bluecore we were having validation which were resulting in truthy outcome for numeric values like 0

Screenshot 2024-09-27 at 5 44 21 PM

This PR approaches to fix the same

What is the related Linear task?

Resolves INT-2722

Alert: https://rudderstack.grafana.net/a/grafana-oncall-app/alert-groups/I41S6Q2NG82DL?perpage=25&start=1&started_at=now-30d_now&status=0&status=1&team=TRBAJ7M5Y8MEJ

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@utsabc utsabc requested a review from a team as a code owner September 27, 2024 12:15
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (4c0c681) to head (998c720).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3766      +/-   ##
===========================================
+ Coverage    88.89%   88.92%   +0.02%     
===========================================
  Files          600      599       -1     
  Lines        32658    32609      -49     
  Branches      7757     7745      -12     
===========================================
- Hits         29032    28998      -34     
- Misses        3318     3334      +16     
+ Partials       308      277      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@utsabc utsabc self-assigned this Sep 27, 2024
@utsabc utsabc merged commit 9cc72f2 into develop Sep 27, 2024
27 checks passed
@utsabc utsabc deleted the fix.blucore branch September 27, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants