Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard Amazon Audience #3727

Merged
merged 14 commits into from
Oct 8, 2024
Merged

feat: onboard Amazon Audience #3727

merged 14 commits into from
Oct 8, 2024

Conversation

anantjain45823
Copy link
Contributor

What are the changes introduced in this PR?

Onboard new destination Amazon Audience.
This needs Proxy due Oauth Support
Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-2604

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 94.69697% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.06%. Comparing base (65a9844) to head (89e20f7).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/v0/destinations/amazon_audience/utils.js 92.45% 4 Missing ⚠️
.../v0/destinations/amazon_audience/networkHandler.js 95.34% 2 Missing ⚠️
src/v0/destinations/amazon_audience/transform.js 96.77% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3727      +/-   ##
===========================================
+ Coverage    88.94%   89.06%   +0.11%     
===========================================
  Files          599      608       +9     
  Lines        32574    32985     +411     
  Branches      7741     7809      +68     
===========================================
+ Hits         28972    29377     +405     
- Misses        3325     3331       +6     
  Partials       277      277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/integrations/destinations/amazon_audience/network.ts Dismissed Show dismissed Hide dismissed
test/integrations/destinations/amazon_audience/network.ts Dismissed Show dismissed Hide dismissed
test/integrations/destinations/amazon_audience/network.ts Dismissed Show dismissed Hide dismissed
test/integrations/destinations/amazon_audience/router/data.ts Dismissed Show dismissed Hide dismissed
test/integrations/destinations/amazon_audience/router/data.ts Dismissed Show dismissed Hide dismissed
@utsabc utsabc self-requested a review October 8, 2024 12:57
package.json Outdated Show resolved Hide resolved
utsabc
utsabc previously approved these changes Oct 8, 2024
Copy link

sonarqubecloud bot commented Oct 8, 2024

@Gauravudia Gauravudia merged commit 5ac8186 into develop Oct 8, 2024
24 checks passed
@Gauravudia Gauravudia deleted the feat.amazon_audience branch October 8, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants