Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add validation for concurrent_modification error #3654

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

ItsSudip
Copy link
Member

What are the changes introduced in this PR?

We are returning 400 status code for concurrent_modification error but we should retry those events. So added a validation to return 500 status code.

What is the related Linear task?

Resolves INT-2536

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@ItsSudip ItsSudip requested review from a team and sivashanmukh as code owners August 13, 2024 15:21
@devops-github-rudderstack
Copy link
Contributor

Copy link

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (cb14429) to head (597113f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3654   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files         585      585           
  Lines       31850    31858    +8     
  Branches     7588     7590    +2     
=======================================
+ Hits        28201    28209    +8     
  Misses       3327     3327           
  Partials      322      322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanpj2292 sanpj2292 changed the base branch from main to hotfix/14082024 August 14, 2024 05:52
@sanpj2292 sanpj2292 merged commit 62cdc46 into hotfix/14082024 Aug 14, 2024
20 of 22 checks passed
@sanpj2292 sanpj2292 deleted the fix.garl branch August 14, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants