Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect logger import #1874

Merged
merged 1 commit into from
Feb 20, 2023
Merged

fix: incorrect logger import #1874

merged 1 commit into from
Feb 20, 2023

Conversation

ujjwal-ab
Copy link
Contributor

Description of the change

fix incorrect logger import in snapchat conversion destination

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab ujjwal-ab requested review from utsabc and ItsSudip February 19, 2023 08:12
@ujjwal-ab ujjwal-ab self-assigned this Feb 19, 2023
@ujjwal-ab ujjwal-ab requested a review from a team as a code owner February 19, 2023 08:12
@ujjwal-ab ujjwal-ab changed the title fix(snapchat_conversion):fix incorrect logger import fix(snapchat conversion):fix incorrect logger import Feb 19, 2023
@ujjwal-ab ujjwal-ab changed the title fix(snapchat conversion):fix incorrect logger import fix(destination) : fix incorrect logger import Feb 19, 2023
@ujjwal-ab ujjwal-ab changed the title fix(destination) : fix incorrect logger import fix : incorrect logger import Feb 19, 2023
@ujjwal-ab ujjwal-ab changed the title fix : incorrect logger import fix: incorrect logger import Feb 19, 2023
@ujjwal-ab ujjwal-ab merged commit 7ff1b4a into master Feb 20, 2023
This was referenced Feb 20, 2023
Closed
Merged
@devops-github-rudderstack devops-github-rudderstack deleted the fix/snapchat-conversion-logger branch May 20, 2023 01:30
@github-actions github-actions bot mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@yashasvibajpai yashasvibajpai yashasvibajpai approved these changes

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

Assignees

@ujjwal-ab ujjwal-ab

Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ujjwal-ab @utsabc @yashasvibajpai