Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(integration): algolia in cdk v2 now errors out for non string event names #1867

Merged
merged 1 commit into from
Feb 20, 2023
Merged

fix(integration): algolia in cdk v2 now errors out for non string event names #1867

merged 1 commit into from
Feb 20, 2023

Conversation

shrouti1507
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@shrouti1507 shrouti1507 requested a review from a team as a code owner February 15, 2023 13:03
@shrouti1507 shrouti1507 changed the title fix(integration): Algolia in CDK v2 now errors out for non string event names fix(integration): algolia in cdk v2 now errors out for non string event names Feb 15, 2023
@shrouti1507 shrouti1507 merged commit 5be8891 into master Feb 20, 2023
This was referenced Feb 20, 2023
Closed
Merged
@devops-github-rudderstack devops-github-rudderstack deleted the fix.algolia-cdk2 branch May 16, 2023 01:29
@github-actions github-actions bot mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanpj2292 sanpj2292 sanpj2292 approved these changes

@koladilip koladilip koladilip approved these changes

@sauravlal15 sauravlal15 Awaiting requested review from sauravlal15 sauravlal15 is a code owner automatically assigned from rudderlabs/integrations

@Gauravudia Gauravudia Awaiting requested review from Gauravudia Gauravudia is a code owner automatically assigned from rudderlabs/integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrouti1507 @sanpj2292 @koladilip