feat(integration): rockerbox - allow all properties to be passed over to rockerbox #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utsabc
previously approved these changes
Feb 1, 2023
ItsSudip
approved these changes
Feb 2, 2023
utsabc
approved these changes
Feb 2, 2023
Merged
krishna2020
reviewed
Feb 2, 2023
| // Reject other unmapped events | ||
| if (!eventsHashMap[message.event.toLowerCase()]) { | ||
| throw new ConfigurationError('The event is not associated to a RockerBox event. Aborting!'); | ||
| } else { | ||
| payload.action = eventsHashMap[message.event.toLowerCase()]; | ||
| } | ||
| extractCustomFields(message, payload, ['properties'], ROCKERBOX_DEFINED_PROPERTIES); |
There was a problem hiding this comment.
Write unit test case for extractCustomFields function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review