Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pinterest): add ldp support #1731

Merged
merged 1 commit into from
Jan 3, 2023
Merged

feat(pinterest): add ldp support #1731

merged 1 commit into from
Jan 3, 2023

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Dec 23, 2022 •
edited by anantjain45823
Loading

Description of the change

Add LDP Support

  • Add new field properties.optOutType
  • For Limited Data Processing user need to pass properties.optOutType = LDP
  • properties.optOutType mapped to custom_data.opt_out_type in Pinterest (opt_out_type can accept comma separated values)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Gauravudia Gauravudia requested a review from a team as a code owner December 23, 2022 08:59
@Gauravudia Gauravudia self-assigned this Dec 23, 2022
@Gauravudia Gauravudia added enhancement New feature or request Ready for Review labels Dec 23, 2022
@Gauravudia Gauravudia merged commit a54d074 into master Jan 3, 2023
@github-actions github-actions bot mentioned this pull request Jan 3, 2023
Merged
@github-actions github-actions bot deleted the feat.pinterest-ldp branch March 24, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrouti1507 shrouti1507 shrouti1507 approved these changes

@anantjain45823 anantjain45823 anantjain45823 approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@ujjwal-ab ujjwal-ab Awaiting requested review from ujjwal-ab ujjwal-ab is a code owner automatically assigned from rudderlabs/integrations

Assignees

@Gauravudia Gauravudia

Labels
enhancement New feature or request Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravudia @shrouti1507 @anantjain45823 @ItsSudip