Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trackingplan): error message population #1706

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix(trackingplan): error message population #1706

merged 1 commit into from
Dec 16, 2022

Conversation

Jayachand
Copy link
Collaborator

Description of the change

error property population

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Jayachand Jayachand requested review from a team and sivashanmukh as code owners December 16, 2022 15:09
@Jayachand Jayachand merged commit 72079a7 into master Dec 16, 2022
@github-actions github-actions bot mentioned this pull request Dec 16, 2022
Merged
saikumarrs added a commit that referenced this pull request Dec 16, 2022
@Jayachand @saikumarrs @github-actions
chore(release): sync master to rudder-saas (#1708)
e28d5ba 
* chore(ci): fix the buildspec file for helm chart changes (#1701)

* fix: upgrade base node image in dockerfiles (#1702)

* chore: release 1.9.0 (#1633)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix(trackingplan): error message population (#1706)

Co-authored-by: Sai Kumar Battinoju <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@achettyiitr achettyiitr deleted the fix.trackingplanErrormsg branch December 16, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psrikanth88 psrikanth88 psrikanth88 approved these changes

@achettyiitr achettyiitr achettyiitr approved these changes

@saikumarrs saikumarrs saikumarrs approved these changes

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jayachand @psrikanth88 @achettyiitr @saikumarrs