Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(integration): shopify - fix typo in customer_disabled #1573

Merged
merged 2 commits into from
Nov 15, 2022
Merged

fix(integration): shopify - fix typo in customer_disabled #1573

merged 2 commits into from
Nov 15, 2022

Conversation

yashasvibajpai
Copy link
Member

@yashasvibajpai yashasvibajpai commented Nov 15, 2022 •
edited
Loading

Description of the change

There was a typo in SUPPORTED_TRACK_EVENTS which caused a failure of customer deleted events. This was rectified here.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@yashasvibajpai yashasvibajpai requested a review from a team as a code owner November 15, 2022 09:52
@yashasvibajpai yashasvibajpai self-assigned this Nov 15, 2022
@yashasvibajpai yashasvibajpai changed the title fix(integration): Shopify - correct typo in customer_disabled, add to… fix(integration): shopify - correct typo in customer_disabled, add to… Nov 15, 2022
@utsabc
Copy link
Member

utsabc commented Nov 15, 2022

Please add unit test cases around this

@yashasvibajpai yashasvibajpai changed the title fix(integration): shopify - correct typo in customer_disabled, add to… fix(integration): shopify - fix typo in customer_disabled Nov 15, 2022
@yashasvibajpai yashasvibajpai merged commit cfb5c56 into master Nov 15, 2022
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Merged
@github-actions github-actions bot deleted the fix/shopify-track-map-discrepency branch March 15, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@sanpj2292 sanpj2292 Awaiting requested review from sanpj2292 sanpj2292 is a code owner automatically assigned from rudderlabs/integrations

Assignees

@yashasvibajpai yashasvibajpai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashasvibajpai @utsabc @ItsSudip