Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(destination): stringify the object and array for Clevertap #1554

Merged
merged 11 commits into from
Nov 9, 2022
Merged

feat(destination): stringify the object and array for Clevertap #1554

merged 11 commits into from
Nov 9, 2022

Conversation

sauravlal15
Copy link
Contributor

@sauravlal15 sauravlal15 commented Nov 7, 2022 •
edited by saikumarrs
Loading

Description of the change

This function stringify the payload attributes if it's an array or objects.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • [ ✅] New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@sauravlal15 sauravlal15 added the enhancement New feature or request label Nov 7, 2022
@sauravlal15 sauravlal15 requested a review from a team as a code owner November 7, 2022 08:26
@sauravlal15 sauravlal15 self-assigned this Nov 7, 2022
mihir-4116
mihir-4116 previously approved these changes Nov 7, 2022
View reviewed changes
@sauravlal15 sauravlal15 changed the title feat(Clevertap): stringify the Object and Array from payload feat(clevertap): stringify the object and array from payload Nov 7, 2022
ItsSudip
ItsSudip reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@ItsSudip ItsSudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add unit-test cases here?

@ItsSudip ItsSudip changed the title feat(clevertap): stringify the object and array from payload feat(destination): stringify the object and array for Clevertap Nov 7, 2022
mihir-4116
mihir-4116 previously approved these changes Nov 8, 2022
View reviewed changes
ItsSudip
ItsSudip previously approved these changes Nov 9, 2022
View reviewed changes
@sauravlal15 sauravlal15 dismissed stale reviews from ItsSudip and mihir-4116 via 6dd7e89 November 9, 2022 10:01
ItsSudip
ItsSudip requested changes Nov 9, 2022
View reviewed changes
v0/destinations/clevertap/transform.js Outdated Show resolved Hide resolved
@sauravlal15 sauravlal15 merged commit 1c7b459 into master Nov 9, 2022
@github-actions github-actions bot mentioned this pull request Nov 9, 2022
Merged
@github-actions github-actions bot deleted the feat.Clevertap.validation branch March 15, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsSudip ItsSudip ItsSudip approved these changes

@mihir-4116 mihir-4116 mihir-4116 approved these changes

Assignees

@sauravlal15 sauravlal15

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sauravlal15 @ItsSudip @mihir-4116