feat(destination): singular- add support for other apple os (#1611)

* feat(destination): singular- add support for other apple os * feat(destination): singular- address comments * feat(destination): singular- address comment * feat(destination): singular- add tolowercase for platform
rudderlabs · Nov 30, 2022 · 63f23d8 · 63f23d8
1 parent 0673c2f
commit 63f23d8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/__tests__/data/singular.json b/__tests__/data/singular.json
@@ -1330,7 +1330,7 @@
             "content": "some content"
           },
           "os": {
-            "name": "iOS",
+            "name": "ipados",
             "version": "9"
           },
           "screen": {

diff --git a/v0/destinations/singular/util.js b/v0/destinations/singular/util.js
@@ -19,7 +19,7 @@ const {
   extractCustomFields,
   getValueFromMessage,
   isDefinedAndNotNull,
-  toUnixTimestamp
+  isAppleFamily
 } = require("../../util");
 
 /*
@@ -108,6 +108,11 @@ const platformWisePayloadGenerator = (message, isSessionEvent) => {
   if (!platform) {
     throw new CustomError("[Singular] :: Platform name is missing", 400);
   }
+  // checking if the os is one of ios, ipados, watchos, tvos
+  if (typeof platform === "string" && isAppleFamily(platform.toLowerCase())) {
+    message.context.os.name = "iOS";
+    platform = "iOS";
+  }
   platform = platform.toLowerCase();
   if (!SUPPORTED_PLATFORM[platform]) {
     throw new CustomError("[Singular] :: Platform is not supported");