fix: typo in topic mapping for shopify source (#1566)

rudderlabs · Nov 14, 2022 · 0ecf278 · 0ecf278
1 parent f1b6b94
commit 0ecf278
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 1 deletion.
diff --git a/__tests__/data/shopify_source_input.json b/__tests__/data/shopify_source_input.json
@@ -632,5 +632,46 @@
       "https://www.amazon.co.uk/gp/help/customer/display.html?nodeId=201910530"
     ],
     "updated_at": "2022-01-05T18:16:48+05:30"
+  },
+  {
+    "query_parameters": {
+      "topic": ["checkout_delete"],
+      "writeKey": ["sample-write-key"],
+      "signature": ["rudderstack"]
+    },
+    "admin_graphql_api_id": "gid://shopify/Fulfillment/4124667937024",
+    "created_at": "2022-01-05T18:13:02+05:30",
+    "destination": null,
+    "id": 4124667937024,
+    "line_items": [
+    ],
+    "customer": {
+      "email": "[email protected]",
+      "first_name": "Test",
+      "last_name": "Person"
+    },
+    "billing_address": {
+      "address1": "11 Rani Sankari Lane Patuapara Bhowanipore"
+    },
+    "shipping_address": {
+      "address1": "11 Rani Sankari Lane Patuapara Bhowanipore"
+    },
+    "location_id": 66855371008,
+    "name": "#1002.1",
+    "order_id": 4617255092480,
+    "origin_address": null,
+    "receipt": {},
+    "service": "manual",
+    "shipment_status": null,
+    "status": "success",
+    "tracking_company": "Amazon Logistics UK",
+    "tracking_number": "Sample001test",
+    "tracking_numbers": ["Sample001test"],
+    "tracking_url": "https://www.amazon.co.uk/gp/help/customer/display.html?nodeId=201910530",
+    "tracking_urls": [
+      "https://www.amazon.co.uk/gp/help/customer/display.html?nodeId=201910530"
+    ],
+    "updated_at": "2022-01-05T18:16:48+05:30"
   }
+
 ]
diff --git a/__tests__/data/shopify_source_output.json b/__tests__/data/shopify_source_output.json
@@ -638,5 +638,8 @@
         "zip": "700025"
       }
     }
+  },
+  {
+    "error": "event type checkout_delete not supported"
   }
 ]
diff --git a/v0/sources/shopify/config.js b/v0/sources/shopify/config.js
@@ -23,7 +23,7 @@ const RUDDER_ECOM_MAP = {
 };
 
 const SHOPIFY_TRACK_MAP = {
-  checkout_delete: "Checkout Deleted",
+  checkouts_delete: "Checkout Deleted",
   carts_create: "Cart Create",
   carts_update: "Cart Update",
   fulfillments_create: "Fulfillments Create",
-Original file line number
+Diff line change
@@ Expand Up / @@ -638,5 +638,8 @@ @@
             "zip": "700025"
           }
         }
+      },
+      {
+        "error": "event type checkout_delete not supported"
       }
     ]