Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for hash to bingads offline conversions #5390

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

ItsSudip
Copy link
Member

Description

We are adding support for hashing email and phone for bingads offline conversion destination.

Linear Ticket

resolves INT-3019

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@ItsSudip ItsSudip force-pushed the feat.bingads-offline-conversion branch from fddc1ae to 76c2e03 Compare December 23, 2024 10:05
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.72%. Comparing base (989310c) to head (9ba863b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...nationmanager/bing-ads/offline-conversions/util.go 78.12% 5 Missing and 2 partials ⚠️
...ager/bing-ads/offline-conversions/bulk_uploader.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5390      +/-   ##
==========================================
- Coverage   74.78%   74.72%   -0.06%     
==========================================
  Files         438      438              
  Lines       61296    61331      +35     
==========================================
- Hits        45838    45830       -8     
- Misses      12923    12951      +28     
- Partials     2535     2550      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ItsSudip ItsSudip merged commit 8a186e5 into master Dec 27, 2024
58 checks passed
@ItsSudip ItsSudip deleted the feat.bingads-offline-conversion branch December 27, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants