Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding metadata in the proxy request #2622

Merged
merged 18 commits into from
Nov 2, 2022

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Oct 27, 2022

Description

adding the metadata object in the proxy request to send the destination info inside that to use it in the transformer

Notion Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 43.85% // Head: 43.87% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (03d5e91) compared to base (5c26d1b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2622      +/-   ##
==========================================
+ Coverage   43.85%   43.87%   +0.01%     
==========================================
  Files         187      187              
  Lines       40027    40041      +14     
==========================================
+ Hits        17552    17566      +14     
+ Misses      21376    21375       -1     
- Partials     1099     1100       +1     
Impacted Files Coverage Δ
router/router.go 74.20% <0.00%> (-0.62%) ⬇️
router/transformer/transformer.go 66.66% <ø> (ø)
enterprise/reporting/setup.go 38.09% <0.00%> (-14.29%) ⬇️
enterprise/reporting/reporting.go 8.33% <0.00%> (-1.44%) ⬇️
processor/processor.go 72.11% <0.00%> (+0.87%) ⬆️
middleware/middleware.go 94.82% <0.00%> (+8.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

router/router.go Show resolved Hide resolved
@chandumlg
Copy link
Member

Changes look okay.

But lint & tests are failing. Please address.

Copy link
Member

@chandumlg chandumlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the tests

router/router.go Outdated Show resolved Hide resolved
router/router.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
27.3% 27.3% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants