Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jobsdb): use a different advisory lock for different table prefixes #2575

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Oct 15, 2022

Description

Different table prefixes shouldn't use the same advisory lock.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum force-pushed the jobsdb.advisoryLock branch from 92e094b to 51cd742 Compare October 15, 2022 08:05
@atzoum atzoum marked this pull request as ready for review October 15, 2022 08:05
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Base: 43.97% // Head: 43.97% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (51cd742) compared to base (eb705df).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2575      +/-   ##
==========================================
- Coverage   43.97%   43.97%   -0.01%     
==========================================
  Files         187      187              
  Lines       39076    39082       +6     
==========================================
+ Hits        17185    17187       +2     
- Misses      20810    20813       +3     
- Partials     1081     1082       +1     
Impacted Files Coverage Δ
utils/misc/dbutils.go 0.00% <ø> (ø)
jobsdb/jobsdb.go 68.12% <87.50%> (+0.06%) ⬆️
utils/httputil/server.go 80.76% <0.00%> (-11.54%) ⬇️
warehouse/schema.go 47.82% <0.00%> (-1.16%) ⬇️
config/backend-config/namespace_config.go 73.95% <0.00%> (+3.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants