From 911e4d27dd8ac7c6190cf15d9f3784f42122997b Mon Sep 17 00:00:00 2001
From: Ashish Kulkarni <ashish@kulkarni.dev>
Date: Mon, 2 Jan 2023 23:30:51 +0530
Subject: [PATCH 1/2] bump dependency on faraday-gzip to support JRuby (#594)

* note about 2.0

* clarified version info

* Update README.md

added note about redirect_uri needs to be publicly accessible

* Update README.md

* deser tax_inclusive_amt to numeric type (#589)

match serialization type, fix https://github.com/ruckus/quickbooks-ruby/issues/588

* bump dependency on faraday-gzip to support JRuby

see https://github.com/bodrovis/faraday-gzip/pull/2

* expand CI to cover Ruby 3.2 and JRuby 9.3/9.4

* fix test broken on JRuby due to invalid XML

Co-authored-by: cody caughlan <toolbag@gmail.com>
Co-authored-by: Brian Henry <brian@bitpan.com>
---
 .github/workflows/ci.yml     | 23 +++++++++++++++--------
 Gemfile                      |  2 --
 HISTORY.md                   |  7 +++++--
 README.md                    |  2 ++
 quickbooks-ruby.gemspec      |  2 +-
 spec/fixtures/tax_agency.xml |  6 +++---
 6 files changed, 26 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index edb22659..b50fab56 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -4,18 +4,25 @@ on: [push, pull_request]
 
 jobs:
   test:
-
     runs-on: ubuntu-latest
-
     strategy:
       fail-fast: false
       matrix:
-        ruby: ["2.6", "2.7", "3.0", "3.1", ruby-head]
-        env:
-          - FARADAY_VERSION: "~> 2.0"
-          - FARADAY_VERSION: "~> 1.0"
-
-    env: ${{ matrix.env }}
+        ruby:
+          - "2.6"
+          - "2.7"
+          - "3.0"
+          - "3.1"
+          - "3.2"
+          - "ruby-head"
+          - "jruby-9.3"
+          - "jruby-9.4"
+          - "jruby-head"
+        faraday:
+          - "~> 1.0"
+          - "~> 2.0"
+    env:
+      FARADAY_VERSION: ${{ matrix.faraday }}
     steps:
     - uses: actions/checkout@v2
     - name: Set up Ruby
diff --git a/Gemfile b/Gemfile
index 2d73000c..de6fde28 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,7 +1,5 @@
 source 'http://rubygems.org'
 
-ruby RUBY_VERSION
-
 gem 'pry'
 
 gemspec
diff --git a/HISTORY.md b/HISTORY.md
index 0e2b7866..397efb90 100644
--- a/HISTORY.md
+++ b/HISTORY.md
@@ -1,11 +1,14 @@
+## 2.0.2 (2022-12-28)
+
+* Update dependency on `faraday-gzip` to support JRuby (#594)
+
 ## 2.0.1 (2022-12-27)
 
 Faraday Versions (#593)
 * Test against Faraday 1.x and 2.x
 * Faraday 1.x support for Quickbooks::Service::AccessToken#disconnect
 
-Thanks @jaredmoody and @ ashkulz
-
+Thanks @jaredmoody and @ashkulz
 
 ## 2.0 (2022-11-10)
 
diff --git a/README.md b/README.md
index 5be8343a..736a267b 100644
--- a/README.md
+++ b/README.md
@@ -119,6 +119,8 @@ def oauth_callback
 end
 ```
 
+Your Redirect URI needs to be publicly accessible. If you are still in development and running everything via `localhost` you will need to use a tool like [Ngrok](https://ngrok.com/product/secure-tunnels) to expose your localhost to a public URL with HTTPS.
+
 Most likely you will want to persist the OAuth access credentials so that users don't need to re-authorize your application in every session.
 
 An example database table could have fields likes:
diff --git a/quickbooks-ruby.gemspec b/quickbooks-ruby.gemspec
index b86ca61b..3168bef4 100644
--- a/quickbooks-ruby.gemspec
+++ b/quickbooks-ruby.gemspec
@@ -24,7 +24,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'multipart-post' # promiscuous mode
   gem.add_dependency 'faraday', '< 3.0'
   gem.add_dependency 'faraday-multipart', '~> 1.0'
-  gem.add_dependency 'faraday-gzip', '~> 0.1'
+  gem.add_dependency 'faraday-gzip', '~> 1.0'
 
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'simplecov'
diff --git a/spec/fixtures/tax_agency.xml b/spec/fixtures/tax_agency.xml
index 11c07876..9dbf1485 100644
--- a/spec/fixtures/tax_agency.xml
+++ b/spec/fixtures/tax_agency.xml
@@ -5,7 +5,7 @@
         <CreateTime>2013-12-11T10:59:51-08:00</CreateTime>
         <LastUpdatedTime>2013-12-11T10:59:51-08:00</LastUpdatedTime>
     </MetaData>
-    <DisplayName>First TaxAgency</Name>
-    <TaxTrackedOnPurchases>false</Description>
-    <TaxTrackedOnSales>true</Active>
+    <DisplayName>First TaxAgency</DisplayName>
+    <TaxTrackedOnPurchases>false</TaxTrackedOnPurchases>
+    <TaxTrackedOnSales>true</TaxTrackedOnSales>
 </TaxAgency>

From b6ef0a8058dbb668d68fa459dc0f2afa357d2b96 Mon Sep 17 00:00:00 2001
From: cody caughlan <toolbag@gmail.com>
Date: Mon, 2 Jan 2023 10:04:16 -0800
Subject: [PATCH 2/2] 2.0.2 version bump

---
 lib/quickbooks/version.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/quickbooks/version.rb b/lib/quickbooks/version.rb
index 9d5d985c..f2f235f4 100644
--- a/lib/quickbooks/version.rb
+++ b/lib/quickbooks/version.rb
@@ -1,5 +1,5 @@
 module Quickbooks
 
-  VERSION = "2.0.1"
+  VERSION = "2.0.2"
 
 end