-
Notifications
You must be signed in to change notification settings - Fork 120
Prefetch the v8 source during release #279
Comments
Unfortunately it's not too simple to accomplish that. depot_tools downloads different things depending on the architecture you run it on :(. I welcome any suggestions. I've considered doing it the nodejs way, however this might entail porting over both their gyp build scripts and their patches. |
You're so right, i didn't think about that. The whole system doesn't seem particularly geared for easy packaging, only to cater to google engineers. I will try to reach out to upstream and see what is possible to do. |
This has always been the №1 issue I've had with V8. |
Some sort of issue with depot_tools? Yes. It definitely seems so. I am yet to look into it though. |
I'm glad that there are still people who are interested in making libv8 possible to be installed on platforms like FreeBSD and others. I wish I could finally use it on /BSD, especially because of Discourse. |
@zimbatm For Nix's specific usecase, I think reintroducing the This flag would serve two benefits for Nix—it would allow for a very easy way of bringing a system dependency back into the control of system packaging, and it would allow for Nix to build and compile v8 for their platform separately. Does that make sense to you? Or is there another solution you'd prefer we investigate? |
The issue with using the system v8 is that the API might change. It has caused a few headaches in the past already. As a user, it is suprising when the Gem version doesn't map 1:1 with the v8 version. |
libv8-node fetches a node source tarball, I might look into venturing the source in the |
Closing as libv8-node achieves that goal by design. |
Having the gem dynamically fetch the source at build time makes it hard to do offline installations. In Nix and probably other package managers we sandbox builds and describe all the network dependencies upfront. Having the source inside of the .gem file would make things a lot easier for us.
This would also solve #259 and #253.
Would you be open for me to submit a PR that does this?
The text was updated successfully, but these errors were encountered: