Add URI to http response output in debug mode #4808
Conversation
| @@ -14,7 +14,7 @@ def fetch(uri, options = {}, counter = 0) | |||
| raise HTTPError, "Too many redirects" if counter >= redirect_limit | |||
|
|
|||
| response = request(uri, options) | |||
| Bundler.ui.debug("HTTP #{response.code} #{response.message}") | |||
| Bundler.ui.debug("HTTP #{response.code} #{response.message} #{uri}") | |||
There was a problem hiding this comment.
maybe HTTP GET #{uri} => #{response.code} #{response.message} ?
There was a problem hiding this comment.
@segiddins Works for me, and I can make that change. The only problem I do see with it is the URIs plus query params can be quite lengthy, so putting the URI first might make it hard to quickly find 500 errors if the response code/message are at the end. Thoughts?
There was a problem hiding this comment.
I'm thinking in terms of the message being long? ¯_(ツ)_/¯ If in your experience it's been readable with the URL at the end as it is here, then lets 
There was a problem hiding this comment.
Oh, heh. Yeah, usually the message was something like "Not Modified", so the full thing was just "HTTP 304 Not Modified" (without the URI of course).
|
./spec/bundler/fetcher/downloader_spec.rb:35 needs to be updated, otherwise 👍 |
Useful when mapping completed responses to requests when debugging to determine which requests are still in progress.
NickLaMuro
force-pushed
the
add_url_for_debug_http_response
branch
from
25fcd31 to
4df7986
Compare
|
@segiddins Sorry about that. Like a Typical Developer™, I didn't run tests locally. Fixed now. To be fair, had I done so, I would have ran into the issues I have fixed in #4810. |
|
@homu r+ thanks a bunch! |
|
📌 Commit 4df7986 has been approved by |
…egiddins Add URI to http response output in debug mode Map request response to original URI when printing debug output for http responses for `bundler/fetcher/downloader`. Overview -------- I have recently been debugging some bundler stalling issues and found this addition to the debug output helpful when ruling out if a particular URL was timing out with the `CompactIndex` fetcher as it does it's requests over 25 threads and returns them asynchronously. Getting a bunch of `HTTP 304 Not Modified` isn't as helpful if you are trying to determine how a thread is locking up. Incidentally, this didn't end up helping solving some issues (further PRs will address this), but it seems like a simple debugging addition that could help rule out specific endpoint issues without requiring more [advanced debugging setups](https://gist.github.com/NickLaMuro/e923fc4e55307437a8f0e97ee6429410).
|
☀️ Test successful - status |
Map request response to original URI when printing debug output for http responses for
bundler/fetcher/downloader.Overview
I have recently been debugging some bundler stalling issues and found this addition to the debug output helpful when ruling out if a particular URL was timing out with the
CompactIndexfetcher as it does it's requests over 25 threads and returns them asynchronously. Getting a bunch ofHTTP 304 Not Modifiedisn't as helpful if you are trying to determine how a thread is locking up.Incidentally, this didn't end up helping solving some issues (further PRs will address this), but it seems like a simple debugging addition that could help rule out specific endpoint issues without requiring more advanced debugging setups.