Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Simple Gemfile causes "bundle update" to never finish #3634

Closed
donv opened this issue May 8, 2015 · 6 comments · Fixed by #3635
Closed

Simple Gemfile causes "bundle update" to never finish #3634

donv opened this issue May 8, 2015 · 6 comments · Fixed by #3635

Comments

@donv
Copy link

donv commented May 8, 2015

When running bundle update with the following Gemfile, the command never completes. It runs with "Resolving dependencies" forever. This happens on new installations using RVM for MRI and JRuby.

source 'https://rubygems.org/'

gem 'rails', '<4.2.0'
gem 'actionpack-page_caching'
gem 'simple_workflow'
@segiddins
Copy link
Member

@donv what version of bundler is this with?

@segiddins
Copy link
Member

Hm, the issue here seems to be with a combo of attempt_to_swap and our sorting heuristic... For what it's worth, this resolves for me after a few seconds on 1.9.6.

@segiddins
Copy link
Member

@Who828 what do you think of using dependency.requirements_list.size as part of the sort?

@donv
Copy link
Author

donv commented May 8, 2015

@segiddins This is with bundler 1.9.6.

@donv
Copy link
Author

donv commented May 8, 2015

I left it going for a while and with the simple Gemfile it actually finished in the end:

real    0m46.411s
user    1m10.831s
sys 0m1.680s

That is with all the gems already installed before running the command.

@segiddins
Copy link
Member

Yup, I think I have an optimization in mind that may help this pathological case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants