This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Bundler >= 1.9.0 fails to create gem plugins #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh no! Thank you for fixing this. I will merge it to the 1.9 branch. |
|
@amatsuda it seems like the tests are failing on older Rubies. Could you check the test failures on Travis? |
Since 17a4fc4, any gem name starting with an existing const name has been regarded as "Invalid gem name" by `bundle gem` command. However, "gem-foo" or "rails-bar" should be totally valid and rather preferable naming for plugins for RubyGems/Rails. This commit changes the rule to raise error only when the new gem name fully matches an existing const name.
|
@indirect Oh, sorry! Writing code that works on Ruby 1.8.7..2.2 is so hard! You're really doing a great job here! |
|
Thanks! |
indirect
added a commit
that referenced
this pull request
Apr 30, 2015
…_starting_with_an_existing_const Bundler >= 1.9.0 fails to create gem plugins
amatsuda
deleted the
bundle_gem_hyphenated_gem_name_starting_with_an_existing_const
branch
|
🍰 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 17a4fc4 (#3123), any gem name starting with an
existing const name has been regarded as "Invalid gem name" by
bundle gemcommand.However, "gem-foo" or "rails-bar" should be totally valid and rather preferable
naming for plugins for RubyGems/Rails.
This patch changes the rule to raise error only when the new gem name fully
matches an existing const name.
invalid:
gem,gem-version(becauseGem::Versionalready exists)valid :
gem-foobar,gem-version-foobar(whenFooBarmodule does not exist)