This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Improve generating module name from gem name in gem generator #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the patch! Unfortunately we can't accept it because your change breaks the tests. Could you update this pull request so the tests pass, and add a test for the gem with two dashes in its name? Thanks. |
|
I rewrote the regex to be 1.8 compatible and added a simple test. |
|
The travis fail seems to be a timeout. |
|
Thanks! |
indirect
added a commit
that referenced
this pull request
Apr 1, 2015
Improve generating module name from gem name in gem generator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered the bug that the gem generator would fail on gem names containing two dashes (like
a--a). I updated the module name generator to use a more robust regex based approach.