This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Gem Mirror Support (with specs) (PR #2366) #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirror uri via the bundler configuration. add mirrors like this $ bundle config mirror.http://rubygems.org http://localhost:8081/nexus/content/repositories/rubygems.org
seems in line with conventions in rest of project
Factors the gem mirror code similarly to the local git repos feature. Questions: * RubygemsMirror class does very little other than provide a static location to replace URIs with the desired mirror. Should it exist? * URI normalization is duplicated. Is there a good single location? * Validation of mirror URIs occurs in Settings, which contains no other validation code. Is there a more desirable location for this? * Is there a better solution for case-sensitive URIs?
during Fetching... when run bundle install or bundle update rspec test to make sure mirror prints the mirror source
indirect
added a commit
that referenced
this pull request
Oct 17, 2013
Gem Mirror Support (with specs) (PR #2366) Conflicts: lib/bundler/fetcher.rb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2366