Fixed a bug that was not properly caching gems from all git repositories.

[mtscout6]

Fixed a bug that was not properly caching gems from all git repositories.

[indirect]

What's the bug? How do you reproduce it? Can you write a test for this? Thanks for submitting!

[mtscout6]

In the event that a git repository is hosted on a network share for example
"\MachineName\SharePath" then the base name would evaluate to "/". Which in
turn would cause errors down line where local directories could not be
created to cache the git repository. I am still new to ruby (I've worked
with it for two weeks), I'd be more than happy to look into some unit tests
for this. Could you point me in the right direction so I can learn how to
unit test in ruby?

On Sat, Jun 18, 2011 at 00:57, indirect <
[email protected]>wrote:

What's the bug? How do you reproduce it? Can you write a test for this?
Thanks for submitting!

Reply to this email directly or view it on GitHub:
#1253 (comment)

[mtscout6]

In my attempt to figure out the tests I have encountered an interesting error. I saw that you have a rake file which fires off the specs, however they fail on my machine. I assumed that I should first run "rake spec:dep" which succeeded successfully. Then I ran "rake spec" which I believe is supposed to run the specs and if failed with the following error:

Run gem install win32-open3 to be able to run specs
rake aborted!

I tried doing as it said and ran "gem install win32-open3" which failed with the following error:

ERROR: Error installing win32-open3:
win32-open3 requires Ruby version < 1.9.0.

I then tried installing Ruby 1.8.6 and tried running the specs. That also failed miserably. What am I doing wrong, and/or what do I need to install to run those specs?

[indirect]

Unfortunately, none of the bundler developers use windows. That means the specs don't run (that I am aware of) at present. It is on my list of things to improve, but I'm not sure how soon I'll be able to get to it.

On Jun 20, 2011, at 12:44 PM, mtscout6 [email protected] wrote:

In my attempt to figure out the tests I have encountered an interesting error. I saw that you have a rake file which fires off the specs, however they fail on my machine. I assumed that I should first run "rake spec:dep" which succeeded successfully. Then I ran "rake spec" which I believe is supposed to run the specs and if failed with the following error:

Run gem install win32-open3 to be able to run specs
rake aborted!

I tried doing as it said and ran "gem install win32-open3" which failed with the following error:

ERROR: Error installing win32-open3:
win32-open3 requires Ruby version < 1.9.0.

I then tried installing Ruby 1.8.6 and tried running the specs. That also failed miserably. What am I doing wrong, and/or what do I need to install to run those specs?

Reply to this email directly or view it on GitHub:
#1253 (comment)

[mtscout6]

Ok, I installed a linux vm and was able to run those tests. I have also added a test that covers my change. I also changed my original request so the cache isn't creating an "Undetermined" folder anymore, instead I modified the regex to handle network share paths.

[indirect]

Sounds great. Thanks!

[mtscout6]

Is everything good for this to be pulled in, or is there something else you would like to see included? I have given this fix to my co-workers, but would like to see this fix in place so we don't have to keep updating from my fork.

[indirect]

Oh, sorry, I just haven't had time to run the tests and merge this yet. I should be able to get to it this weekend. Thanks again!

[mtscout6]

I just merged with the latest from your branch so that should at least make things a little less painful for ya. Thanks for looking at this.