Add text testimonials, addressing #4407 #6097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary images
jonathanmeneses
requested review from
compwron,
FireLemons and
elasticspoon
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary images
What github issue is this PR for, if any?
Resolves #4407
What changed, and why?
I updated the text in the existing Lorem ipsum testimonials from the images provided.
I did this, as a departure from the requirements listed in the issue, because:
The files provided are PNGs and have a different background than the current testimonials section, so just pasting them in would look like this:
If you change the background of the section (which I neither recommend nor think was the intent of this issue), it looks like this:
Doing this
How is this tested? (please write tests!) 💖💪
I did not add tests as I simply updated copy.
Screenshots please :)
Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.
local url changed: http://localhost:3000/#testimonials
Feelings gif (optional)
No feelings gif, but a little nervous as this is my first contribution to a Ruby For Good project, and i'm not following the issue directions. I do think this adds value to an already long-open issue!