Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully shutdown the browser on .quit #448

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Conversation

sloanesturz
Copy link
Contributor

Fixes #418 - #418 (comment)

In my application, I found that my sessions to my Browserless server were staying open after I called .quit. When I invoke this command, the sessions more gracefully exit and the server gives back its resources.

@route route merged commit e052e63 into rubycdp:main Feb 25, 2024
5 checks passed
@route
Copy link
Member

route commented Feb 25, 2024

Merged manually with changes. I only wanted it to be a dedicated command. quit handles it completely different from ruby side, close closes it from browser side.

@sloanesturz sloanesturz deleted the sloane/quit branch February 25, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browser.quit doesn't close session
2 participants