From 1794e59755850b6cf59d51a9fc83a3b220cf9bd9 Mon Sep 17 00:00:00 2001 From: James Reid-Smith Date: Sun, 15 Dec 2024 08:24:50 -0500 Subject: [PATCH] Fix iPad Pro navigation not shown (#1236) Found this issue when I was debugging the navigation toggle. I noticed it first in the chrome dev tools, but it was also reproducible on an iPad Pro. Symptom: - On iPad Pro, the navigation section is hidden but there's enough space to show it. Making the user have to click the hamburger button to show it but it's not necessary to hide the navigation section. - On desktop, the navigation section is shown. - On mobile, the navigation section is hidden until the hamburger button is clicked. Fix: - The javascript code was matching 1024px instead of 1023px. The media sections of the css was altering the layout on 1024px. So ipad got the full desktop layout but the navigation section was hidden. --- lib/rdoc/generator/template/darkfish/js/darkfish.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rdoc/generator/template/darkfish/js/darkfish.js b/lib/rdoc/generator/template/darkfish/js/darkfish.js index aeb8526344..ed3893379d 100644 --- a/lib/rdoc/generator/template/darkfish/js/darkfish.js +++ b/lib/rdoc/generator/template/darkfish/js/darkfish.js @@ -99,7 +99,7 @@ function hookSidebar() { navigationToggle.ariaExpanded = navigationToggle.ariaExpanded !== 'true'; }); - var isSmallViewport = window.matchMedia("(max-width: 1024px)").matches; + var isSmallViewport = window.matchMedia("(max-width: 1023px)").matches; if (isSmallViewport) { navigation.hidden = true; navigationToggle.ariaExpanded = false;