New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In one test, restoration branches are reversed #146

Closed

MarkDBlackwell opened this issue Jul 16, 2016 · 0 comments

Contributor

MarkDBlackwell commented Jul 16, 2016 •

edited

Loading

In test/test_rake_application.rb, after:

    def test_terminal_columns
      old_rake_columns = ENV['RAKE_COLUMNS']

regarding the following, conditional branches which tear down the test (see here):

    ensure
      if old_rake_columns
        ENV['RAKE_COLUMNS'].delete
      else
        ENV['RAKE_COLUMNS'] = old_rake_columns
      end
    end

shouldn't these branches properly be reversed (as below)?:

    ensure
      if old_rake_columns
        ENV['RAKE_COLUMNS'] = old_rake_columns
      else
        ENV['RAKE_COLUMNS'].delete
      end
    end

The text was updated successfully, but these errors were encountered:

hsbt closed this as completed in

f413799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment