From 31ffd940c9f260a239e6c7acd55118bfee2bdfe3 Mon Sep 17 00:00:00 2001 From: Jim Weirich Date: Sat, 10 Nov 2012 23:55:25 -0500 Subject: [PATCH 1/2] Use proper system path separator in test. Provided by luis lavena. --- test/test_rake_application_options.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test_rake_application_options.rb b/test/test_rake_application_options.rb index 320db5020..004b8ef3a 100644 --- a/test/test_rake_application_options.rb +++ b/test/test_rake_application_options.rb @@ -146,7 +146,8 @@ def test_rakefile end def test_rakelib - flags(['--rakelibdir', 'A:B:C'], ['--rakelibdir=A:B:C'], ['-R', 'A:B:C'], ['-RA:B:C']) do |opts| + dirs = %w(A B C).join(File::PATH_SEPARATOR) + flags(['--rakelibdir', dirs], ["--rakelibdir=#{dirs}"], ['-R', dirs], ["-R#{dirs}"]) do |opts| assert_equal ['A', 'B', 'C'], opts.rakelib end end From caefbd3980ddae43eaeb88757f5810e1f8d1a7df Mon Sep 17 00:00:00 2001 From: Jim Weirich Date: Sat, 10 Nov 2012 23:56:18 -0500 Subject: [PATCH 2/2] Use skip rather than "puts WARNING:" when test can't be performed. Provided by Luis Lavena. --- test/test_rake_functional.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_rake_functional.rb b/test/test_rake_functional.rb index 710b0947e..ad59f7b9f 100644 --- a/test/test_rake_functional.rb +++ b/test/test_rake_functional.rb @@ -435,7 +435,7 @@ def test_signal_propagation_in_tests assert_match(/ATEST/, @out) refute_match(/BTEST/, @out) else - puts "\nWARNING: Signal detect seems broken on this system (#{__FILE__}:#{__LINE__})" + skip "Signal detect seems broken on this system" end end