From e7e11037118a2737bdc941fe1aa244bd57aa5579 Mon Sep 17 00:00:00 2001 From: SHIBATA Hiroshi Date: Tue, 28 Jun 2016 15:08:28 +0900 Subject: [PATCH 1/3] added helper method for rbx --- test/helper.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/helper.rb b/test/helper.rb index f8f1fe106..7eb560eea 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -115,5 +115,9 @@ def jruby9? jruby? && (JRUBY_VERSION >= '9.0.0.0') end + def rbx? + RUBY_ENGINE == 'rbx' + end + include RakefileDefinitions end From d36cc95f294077919f0cfc693eace439e9921870 Mon Sep 17 00:00:00 2001 From: SHIBATA Hiroshi Date: Tue, 28 Jun 2016 15:10:53 +0900 Subject: [PATCH 2/3] skip broken test with rbx --- test/test_private_reader.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_private_reader.rb b/test/test_private_reader.rb index f86d4249b..895c6a05d 100644 --- a/test/test_private_reader.rb +++ b/test/test_private_reader.rb @@ -24,6 +24,7 @@ def setup end def test_private_reader_is_private + skip if rbx? assert_private do @sample.reader end assert_private do @sample.a end end From 6a94c543b624b48006f21b499a7802839e2315af Mon Sep 17 00:00:00 2001 From: SHIBATA Hiroshi Date: Tue, 28 Jun 2016 15:12:03 +0900 Subject: [PATCH 3/3] remove allow_failures, their are skipped in tests --- .travis.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index 934403400..2f5898ae4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -18,11 +18,6 @@ before_install: before_script: - unset JRUBY_OPTS script: ruby -Ilib exe/rake -matrix: - allow_failures: - - rvm: jruby-head - - rvm: rbx - - rvm: rbx-2 notifications: email: - hsbt@ruby-lang.org