libressl build fix warning TS_time_cb on libressl expects an long lon… #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TS_time_cb on libressl expects an long long/time_t 64 bits long instead.
|
Sorry for the delayed response. I'm changing the target branch because the issue exists in 2.2.x too, not just in master. |
rhenium
force-pushed
the
libressl_fix
branch
from
a82a37a
to
4c99f57
Compare
botovq
reviewed
Oct 17, 2021
| ossl_tsfac_time_cb(struct TS_resp_ctx *ctx, void *data, long *sec, long *usec) | ||
| #else | ||
| ossl_tsfac_time_cb(struct TS_resp_ctx *ctx, void *data, time_t *sec, long *usec) | ||
| #endif | ||
| { | ||
| *sec = *((long *)data); |
There was a problem hiding this comment.
This (long *) cast should be adjusted as well.
There was a problem hiding this comment.
data points to the lgen_time variable in ossl_tsfac_create_ts(). long → time_t conversion can happen on this line, though.
These can be updated too, but I was reluctant to create more #ifdefs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g/time_t 64 bits long instead.