Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL::SSL::SSLServer#listen default argument value #286

Closed
thekuwayama opened this issue Nov 3, 2019 · 2 comments
Closed

OpenSSL::SSL::SSLServer#listen default argument value #286

thekuwayama opened this issue Nov 3, 2019 · 2 comments

Comments

@thekuwayama
Copy link
Contributor

thekuwayama commented Nov 3, 2019 •
edited
Loading

OpenSSL::SSL::SSLServer#listen default argument backlog is 5.
It is sometimes less than TCPServer#listen default argument Socket::SOMAXCONN.

For example, on macOS Socket::SOMAXCONN is defined at sys/socket.h and its value is 128.

I think that there are solutions like below

  • use Socket::SOMAXCONN (but neet to require socket)
  • define constant that is related to SOMAXCONN
@ioquatix
Copy link
Member

ioquatix commented Nov 3, 2019

I think require socket is okay.

@thekuwayama
Copy link
Contributor Author

@ioquatix Thank you for comments. 😄
I send a PR!

@thekuwayama thekuwayama mentioned this issue Nov 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ioquatix @thekuwayama