From b0e4b7cf3ea9564638dfffc5d31734602d6de8e4 Mon Sep 17 00:00:00 2001 From: Naoto Ono Date: Sat, 19 Nov 2022 23:18:37 +0900 Subject: [PATCH] CDP: do not override `UI_ServerBase::readline` Recently, random failures such as `Timeout::Error` and `Errno::ECONNREFUSED` have been occurring. The reason for the error in CDP test is that UI_ServerBase::readline is overridden in CDP. continue is executed as a debug command because UI_CDP::readline returns continue if @q_msg is nil. See ono-max#8 for information on how to reproduce the error. --- lib/debug/server_cdp.rb | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/debug/server_cdp.rb b/lib/debug/server_cdp.rb index ebe23b464..aa3ede9f1 100644 --- a/lib/debug/server_cdp.rb +++ b/lib/debug/server_cdp.rb @@ -628,12 +628,6 @@ def cleanup_reader ## Called by the SESSION thread - def readline prompt - return 'c' unless @q_msg - - @q_msg.pop || 'kill!' - end - def respond req, **result send_response req, **result end