Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let BigDecimal#quo accept precision #216

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Conversation

mrkn
Copy link
Member

@mrkn mrkn commented Dec 9, 2021

Fix GH-214.

@mrkn
Copy link
Member Author

mrkn commented Dec 9, 2021

TODO:

  • Support larger precision than the precision of the default result.

@mrkn mrkn marked this pull request as draft December 9, 2021 13:28
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, a casual reader, it looks good.

@mrkn
Copy link
Member Author

mrkn commented Dec 9, 2021

What did you read? This PR isn't completed yet...

@olleolleolle
Copy link
Contributor

@mrkn I read the carefully-worded documentation! :-)

@mrkn
Copy link
Member Author

mrkn commented Dec 9, 2021

OK, I see. Thank you for checking the documentation part. But it needs to be modified after I will implement the longer precision support. Could you please check the update later.

By the way, the approval check only for the documentation part is noisy to me because the main topic of this PR is updating the logic of BigDecimal#quo. Could you please stop checking approval only for the documentation part to non-documentation PRs? Instead, it's easier to understand your intention that telling your opinion in comments at the documentation lines.

@mrkn mrkn force-pushed the BigDecimal_quo_with_precision branch from 0050b4a to d1c9430 Compare December 14, 2021 02:18
@mrkn
Copy link
Member Author

mrkn commented Dec 14, 2021

@olleolleolle Could you check the documentation update?

@mrkn mrkn marked this pull request as ready for review December 16, 2021 06:56
@mrkn
Copy link
Member Author

mrkn commented Dec 16, 2021

@olleolleolle I'll merge this. Please create a new PR to fix the documentation if you find some mistakes.

@mrkn mrkn merged commit 13e0e93 into master Dec 16, 2021
@mrkn mrkn deleted the BigDecimal_quo_with_precision branch December 16, 2021 06:57
@olleolleolle
Copy link
Contributor

(Reads perfectly, thanks!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

BigDecimal#quo should accept a precision argument
2 participants