-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let BigDecimal#quo accept precision #216
Conversation
TODO:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, a casual reader, it looks good.
What did you read? This PR isn't completed yet... |
@mrkn I read the carefully-worded documentation! :-) |
OK, I see. Thank you for checking the documentation part. But it needs to be modified after I will implement the longer precision support. Could you please check the update later. By the way, the approval check only for the documentation part is noisy to me because the main topic of this PR is updating the logic of |
0050b4a
to
d1c9430
Compare
@olleolleolle Could you check the documentation update? |
@olleolleolle I'll merge this. Please create a new PR to fix the documentation if you find some mistakes. |
(Reads perfectly, thanks!) |
Fix GH-214.