Add support for uppercased date format directives #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radar
reviewed
Feb 25, 2019
lib/i18n/tests/localization/date.rb
Outdated
| test "localize Date: given an abbreviated month name format it returns the correct abbreviated month name" do | ||
| # TODO should be Mrz, shouldn't it? | ||
| assert_equal 'Mar', I18n.l(@date, :format => '%b', :locale => :de) | ||
| end | ||
|
|
||
| test "localize Date: given an abbreviated and uppercased month name format it returns the correct abbreviated month name in upcase" do | ||
| # TODO should be Mrz, shouldn't it? |
There was a problem hiding this comment.
Can this TODO be resolved please?
radar
approved these changes
Feb 25, 2019
|
Sounds good! I've resolved the TODOs updating the month abbreviation, using https://github.com/unicode-cldr/cldr-dates-full/blob/6227cc013572391189a63350cec2544f0e0b3624/main/de/ca-gregorian.json#L63 as reference. |
radar
approved these changes
Feb 26, 2019
|
Excellent! Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes: #463
Certain Ruby uppercased strftime directives are not parsed correctly in
i18n, namely%^A,%^a,%^B, and%^b. These directives will always return the english version of the string.Before
Solution
Added support for the following uppercased date format directives:
%^A,%^a,%^B, and%^bAfter
cc: @blaszczakphoto @radar