Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.3 && cookiejar = ArgumentError #2394

Closed
ericproulx opened this issue Dec 28, 2023 · 1 comment · Fixed by #2395
Closed

Ruby 3.3 && cookiejar = ArgumentError #2394

ericproulx opened this issue Dec 28, 2023 · 1 comment · Fixed by #2395

Comments

@ericproulx
Copy link
Contributor

While testing Ruby 3.3, cookiejar doesn't seem to work. rspec fails with

ArgumentError:
  wrong number of arguments (given 3, expected 1..2)
# /usr/local/bundle/gems/ruby/3.3.0/gems/cookiejar-0.3.3/lib/cookiejar/cookie_validation.rb:48:in `initialize'
# /usr/local/bundle/gems/ruby/3.3.0/gems/cookiejar-0.3.3/lib/cookiejar/cookie_validation.rb:48:in `new'
# /usr/local/bundle/gems/ruby/3.3.0/gems/cookiejar-0.3.3/lib/cookiejar/cookie_validation.rb:48:in `<module:CookieValidation>'
# /usr/local/bundle/gems/ruby/3.3.0/gems/cookiejar-0.3.3/lib/cookiejar/cookie_validation.rb:25:in `<module:CookieJar>'
# /usr/local/bundle/gems/ruby/3.3.0/gems/cookiejar-0.3.3/lib/cookiejar/cookie_validation.rb:5:in `<top (required)>'
# /usr/local/bundle/gems/ruby/3.3.0/gems/cookiejar-0.3.3/lib/cookiejar/cookie.rb:3:in `<top (required)>'
# /usr/local/bundle/gems/ruby/3.3.0/gems/cookiejar-0.3.3/lib/cookiejar.rb:1:in `<top (required)>'
# /usr/local/bundle/gems/bundler-2.4.22/lib/bundler.rb:187:in `require'
# ./spec/spec_helper.rb:9:in `<top (required)>'

It's only used in test and we can easily isolate the specs.

@dblock
Copy link
Member

dblock commented Dec 28, 2023

Is this https://github.com/dwaite/cookiejar? It was archived a while ago, so I think it's time to move on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants