-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converting :values range to enum #235
Labels
Comments
This has been discussed and is definitely a problem, I'd appreciate a PR/fix. |
So, any good idea? |
@LeFnord can we close this issue? As far as I can see it has been fixed with the PR in the previous comment. |
think yes, in the master (OAPI2.0) the implementation is similar |
I have no opinions here, do your thing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Exctacted from #233 and #234
Converting :values ranges to enums (arrays) in docs might not be the best idea.
It may lead to poor performance and huge JSON docs in case of large ranges.
I think the proper solution would be not to convert ranges to enums at all. However, this feature was in the release and some people might be using it.
Also we could try some dirty hack like convert to an array only if Range#size is less then some amount (say, 50). But that seems very odd to me.
The text was updated successfully, but these errors were encountered: