Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The schemes tag is hard coded to https/http #380

Closed
wleeper opened this issue Apr 13, 2016 · 3 comments
Closed

The schemes tag is hard coded to https/http #380

wleeper opened this issue Apr 13, 2016 · 3 comments

Comments

@wleeper
Copy link
Contributor

wleeper commented Apr 13, 2016

By hard coding the schemes tag sites that use http are broken by default. You can use the try button because it 'tries' to use https.

This needs to detect the scheme being used to render and use that.

Something like this:

      if schemes.is_a?(Proc)
        schemes.call(request)
      elsif schemes.is_a?(String)
        [schemes]
      elsif schemes.is_a?(Array)
        schemes
      else
        nil
      end
@wleeper
Copy link
Contributor Author

wleeper commented Apr 13, 2016

Looking at http://swagger.io/specification/ it appears the default should be to not include it.

@LeFnord
Copy link
Member

LeFnord commented Apr 13, 2016

yeap, please replace this line endpoint.rb#L30
through your method and make a PR

@LeFnord
Copy link
Member

LeFnord commented Apr 14, 2016

solved with #382

@LeFnord LeFnord closed this as completed Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants