-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enum values aren't exposed in swagger json #118
Comments
Can you please check against HEAD, I believe this has been fixed by https://github.com/tim-vandecasteele/grape-swagger/pull/87. |
Just checked. defaultValue is fixed, but not enum. |
Ok, would be helpful if you could PR a test (and maybe a fix :)) that reproduces this. Thanks. |
Happy to, but I'll need to refactor form_params_spec.rb first. The single test for all of the generated JSON isn't granular enough for good testing. If something in there fails, you can't tell what went wrong without a difficult string comparison. Much better to break it up into smaller assertions. |
Totally agree. |
#132 Might fix this. Take a look. |
Looks like this is fixed by #132. Haven't tested it yet though. |
I am going to close this, please reopen bugs if #132 is not it. |
Verified that it's working. Thanks! |
results in
It would be nice if this used defaultValue and enum from the swagger spec.
The text was updated successfully, but these errors were encountered: