Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include: '**' option not working on serailizers #69

Closed
JWesorick opened this issue Apr 7, 2017 · 8 comments
Closed

include: '**' option not working on serailizers #69

JWesorick opened this issue Apr 7, 2017 · 8 comments
Labels

Comments

@JWesorick
Copy link

Per rails-api/active_model_serializers#2081 I'm trying to include all levels for one of my endpoints. But it seems the includes option isn't working with this gem.

@dblock dblock added the bug? label Apr 7, 2017
@drn
Copy link
Member

drn commented Apr 11, 2017

@JWesorick, are you using v1.5.0, master, or another version? Should be an easy fix, but that info would help point us in the right direction

@JWesorick
Copy link
Author

v1.5.0

@drn
Copy link
Member

drn commented Apr 11, 2017

Got it - I'll dig

@drn
Copy link
Member

drn commented Apr 24, 2017

@JWesorick - can you try out these changes? #73

gem 'grape-active_model_serializers',
  github: 'ruby-grape/grape-active_model_serializers',
  branch: 'pass-ams-options'

@JWesorick
Copy link
Author

@drn Yep that works!

@drn
Copy link
Member

drn commented Apr 24, 2017

Awesome, sorry for the delay. Been hectic at work. I'll get this merged in sometime over the next few days and release a new gem version

@JWesorick
Copy link
Author

Thanks!

@drn
Copy link
Member

drn commented Apr 26, 2017

v1.5.1 has been released!

@drn drn closed this as completed Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants