Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Rails/DynamicFindBy #500

Merged

Conversation

koic
Copy link
Member

@koic koic commented May 28, 2021

This PR fixes a false positive for Rails/DynamicFindBy when using dynamic finder with hash.

It prevents the following incorrect auto-correction (syntax error).

 def test_find_by_id_with_hash
   assert_nothing_raised do
-    Post.find_by_id(limit: 1)
+    Post.find_by(id: limit: 1)
   end
 end

 def test_find_by_title_and_id_with_hash
   assert_nothing_raised do
-    Post.find_by_title_and_id("foo", limit: 1)
+    Post.find_by(title: 'foo', id: limit: 1)
   end
 end

Refer rails/rails#25671


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

This PR fixes a false positive for `Rails/DynamicFindBy`
when using dynamic finder with hash.

It prevents the following incorrect auto-correction (syntax error).

```diff
 def test_find_by_id_with_hash
   assert_nothing_raised do
-    Post.find_by_id(limit: 1)
+    Post.find_by(id: limit: 1)
   end
 end

 def test_find_by_title_and_id_with_hash
   assert_nothing_raised do
-    Post.find_by_title_and_id("foo", limit: 1)
+    Post.find_by(title: 'foo', id: limit: 1)
   end
 end
```

Refer rails/rails#25671
@koic koic merged commit 4f432ee into rubocop:master May 29, 2021
@koic koic deleted the fix_false_positive_for_rails_dynamic_find_by_cop branch May 29, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant