Update The Rails Style Guide URL #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up rubocop/rubocop#7120. This PR updates the Rails Style Guide URL.
koic
force-pushed
the
update_rails_style_guide_url
branch
from
80a065d to
2f781ca
Compare
|
👍 |
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Aug 16, 2019
Fixes rubocop#88. This PR fixes style guide URLs when specifying `rubocop --display-style-guide` option. The following is an execution using RuboCop Rails. ```console % bundle exec rubocop --display-style-guide --only Style/StringLiterals Inspecting 2 files C. Offenses: Gemfile:3:8: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rails.rubystyle.guide#consistent-string-literals) source "https://rubygems.org" ^^^^^^^^^^^^^^^^^^^^^^ 2 files inspected, 1 offense detected ``` The correct URL is `https://rubystyle.guide#consistent-string-literals` instead of `https://rails.rubystyle.guide#consistent-string-literals`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rubocop/rubocop#7120.
This PR updates the Rails Style Guide URL.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.