Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested cop: Avoid instance variables in helpers #19

Closed
andyw8 opened this issue Nov 25, 2018 · 2 comments
Closed

Suggested cop: Avoid instance variables in helpers #19

andyw8 opened this issue Nov 25, 2018 · 2 comments
Labels
feature request Request for new functionality

Comments

@andyw8
Copy link
Contributor

andyw8 commented Nov 25, 2018 •
edited
Loading

I was reminded of this principal when reading Noel Rappin's book, Rails 5 Test Prescriptions:

If for some reason your helper method requires a specific instance variable to be set, cut that out immediately; it’s a bad idea.
@Drenmi Drenmi added the feature request Request for new functionality label Nov 26, 2018
@Drenmi
Copy link
Contributor

Drenmi commented Nov 26, 2018

Sounds like a very sensible recommendation. 🙂 Are you interested in opening a PR for it @andyw8?

@andyw8
Copy link
Contributor Author

andyw8 commented Nov 26, 2018

I may, but it could be a while before I get to it.

@andyw8 andyw8 mentioned this issue Dec 28, 2018
Merged
@koic koic closed this as completed in #29 Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Request for new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andyw8 @Drenmi