Add post_condition_loop? and loop_keyword? for Node
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
force-pushed
the
loop-related-predicates
branch
from
40e456f
to
83855de
Compare
marcandre
requested changes
Jun 15, 2020
fatkodima
force-pushed
the
loop-related-predicates
branch
from
83855de
to
542af45
Compare
fatkodima
changed the title
post_condition_loop? and loop? for Nodepost_condition_loop? and loop_keyword? for Node
|
Added falsey tests for |
fatkodima
force-pushed
the
loop-related-predicates
branch
from
542af45
to
05ab2c5
Compare
|
Sorry for the delay. Good work. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rubocop-hq/rubocop-performance/pull/140/files#r439819074
There is already a second usage of such constants in the main repository:
https://github.com/rubocop-hq/rubocop/blob/eb3d358363a9f88a6ec2be485414f74b5f1b8878/lib/rubocop/cop/variable_force.rb#L46-L47